linux-kernel - Re: [PATCH 13/22] tools lib traceevent: Add cfg80211 plugin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131123042730.024c4049@gandalf.local.home>
Date:	Sat, 23 Nov 2013 04:27:30 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Jiri Olsa <jolsa@...hat.com>, linux-kernel@...r.kernel.org,
	Corey Ashford <cjashfor@...ux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...e.hu>, Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	David Ahern <dsahern@...il.com>
Subject: Re: [PATCH 13/22] tools lib traceevent: Add cfg80211 plugin

On Sat, 23 Nov 2013 00:16:14 +0900
Namhyung Kim <namhyung@...nel.org> wrote:

 
> [SNIP]
> > +unsigned long long process___le16_to_cpup(struct trace_seq *s,
> > +					  unsigned long long *args)
> > +{
> > +	uint16_t *val = (uint16_t *) args[0];
> > +	return val ? (long long) le16toh(*val) : 0;
> > +}
> > +
> > +int PEVENT_PLUGIN_LOADER(struct pevent *pevent)
> > +{
> > +	pevent_register_print_function(pevent,
> > +				       process___le16_to_cpup,
> > +				       PEVENT_FUNC_ARG_INT,
> 
> Just a nitpick.  The function should return int or the return type
> should be _LONG for consistency.

As stated in another reply, the return type is not for the callback, but
instead for the function it is representing.

-- Steve

> 
> Thanks,
> Namhyung
> 
> > +				       "__le16_to_cpup",
> > +				       PEVENT_FUNC_ARG_PTR,
> > +				       PEVENT_FUNC_ARG_VOID);
> > +	return 0;
> > +}
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/