linux-kernel - Re: [PATCH 14/22] tools lib traceevent: Update kvm plugin with is_writable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131123042815.0e03ca96@gandalf.local.home>
Date:	Sat, 23 Nov 2013 04:28:15 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Jiri Olsa <jolsa@...hat.com>, linux-kernel@...r.kernel.org,
	Corey Ashford <cjashfor@...ux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...e.hu>, Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	David Ahern <dsahern@...il.com>
Subject: Re: [PATCH 14/22] tools lib traceevent: Update kvm plugin with
 is_writable_pte helper

On Sat, 23 Nov 2013 00:19:48 +0900
Namhyung Kim <namhyung@...nel.org> wrote:

> 2013-11-21 (목), 12:01 +0100, Jiri Olsa:
> > Adding is_writable_pte print helper function, so the
> > kvmmmu:fast_page_fault print format gets resolved properly.
> > 
> > The diff of 'perf script' output generated by old and new code:
> > (data was generated by 'perf record -e 'kvm:*,kvmmmu:*' -a')
> > 
> > --- script.kvm.old
> > +++ script.kvm.new
> > - qemu-system-x86  3290 [002] 10708.755312: kvmmmu:fast_page_fault: [FAILED TO PARSE] vcpu_id=0 gva=4094486080 error_code=3 sptep=0xffff88019f1e3670 old_spte=336391285 new_spte=336391287 retry=1
> > + qemu-system-x86  3290 [002] 10708.755312: kvmmmu:fast_page_fault: vcpu 0 gva f40ce640 error_code P|W sptep 0xffff88019f1e3670 old 0x140cec75 new 140cec77 spurious 0 fixed 1
> 
> [SNIP]
> > +unsigned long long process_is_writable_pte(struct trace_seq *s,
> > +					   unsigned long long *args)
> > +{
> > +	unsigned long pte = args[0];
> > +	return pte & PT_WRITABLE_MASK;
> > +}
> > +
> >  int PEVENT_PLUGIN_LOADER(struct pevent *pevent)
> >  {
> >  	init_disassembler();
> > @@ -415,5 +425,12 @@ int PEVENT_PLUGIN_LOADER(struct pevent *pevent)
> >  	pevent_register_event_handler(pevent, -1, "kvmmmu",
> >  			"kvm_mmu_prepare_zap_page", kvm_mmu_print_role,
> >  			NULL);
> > +
> > +	pevent_register_print_function(pevent,
> > +				       process_is_writable_pte,
> > +				       PEVENT_FUNC_ARG_INT,
> 
> Same as the previous reply - return type of the function is
> inconsistent.

Actually it's not.

> 
> And please also consider making the function static.

Agreed.

-- Steve

> 
> Thanks,
> Namhyung
> 
> 
> > +				       "is_writable_pte",
> > +				       PEVENT_FUNC_ARG_LONG,
> > +				       PEVENT_FUNC_ARG_VOID);
> >  	return 0;
> >  }
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/