linux-kernel - Re: [PATCH] gpiolib: add missing declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <529317AB.1050600@nvidia.com>
Date:	Mon, 25 Nov 2013 18:26:03 +0900
From:	Alex Courbot <acourbot@...dia.com>
To:	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Alexandre Courbot <gnurou@...il.com>
CC:	Linus Walleij <linus.walleij@...aro.org>,
	Stephen Warren <swarren@...dotorg.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpiolib: add missing declarations

On 11/25/2013 06:28 PM, Mika Westerberg wrote:
> On Mon, Nov 25, 2013 at 06:07:10PM +0900, Alexandre Courbot wrote:
>> On Mon, Nov 25, 2013 at 5:58 PM, Mika Westerberg
>> <mika.westerberg@...ux.intel.com> wrote:
>>> On Sat, Nov 23, 2013 at 02:54:29PM +0900, Alexandre Courbot wrote:
>>>> Add missing declarations and include files to avoid warnings during
>>>> compilation of include/gpio/driver.h.
>>>
>>> It would be good to have those warnings included in the changelog as well.
>>
>> As in, copy-pasting the compiler's output? Isn't the change explicit enough?
>
> If you just do 'git log' you can't see the change itself and that's where
> the changelog should help. If I see some warnings when I build the kernel,
> the first thing I usually do is to check 'git log' against linux-next and
> see if someone has already fixed that warning (grepping the warning message
> from changelog).

Ah, I can see several examples of what you mention indeed. Will add 
these and send a v2.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/