linux-kernel - Re: [PATCH] x86: boot: Fix mixed indentation in a20.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131125101807.GA13385@gmail.com>
Date:	Mon, 25 Nov 2013 11:18:07 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Joe Perches <joe@...ches.com>
Cc:	"H. Peter Anvin" <hpa@...or.com>, Borislav Petkov <bp@...en8.de>,
	Johannes Löthberg <johannes@...iasis.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, x86@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: boot: Fix mixed indentation in a20.c

* Joe Perches <joe@...ches.com> wrote:

> On Tue, 2013-11-19 at 10:24 -0800, H. Peter Anvin wrote:
>
> > I'll take a proper cleanup,
> > but just whitespace... just pointless churn.
> 
> What in your view would be "a proper cleanup" for a20.c?

If a newbie does a meaningful, complete, well done cleanup patch then 
congratulations and any such help is welcome.

If you as a more experienced kernel developer do a cleanup as part of 
some real work then sure, all such cleanups are welcome and they are a 
natural part of development work.

So a standalone cleanup patch to a20.c from _you_ would probably not 
qualify, almost by definition: your first patch was applied 7 years 
ago, you are by far not a newbie anymore, yet you seem to be mostly 
stuck on the 'cleanups and trivialities' level! Sheesh!

My message to the buerocrat Joe Perches is: please leave trivial and 
printk patches to newbies, you need to raise to the next level of 
kernel development already.

FYI, Linux is a meritocracy, not a bureaucracy: creating self-serving 
churn and attention-seeking but unimportant patches is not the way to 
gain kernel development credibility long term, and eventually people 
start protecting against your increasing abuse of the development 
process. IMHO.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/