linux-kernel - Re: [PATCH 0024] asm-generic: Rename int-ll64.h to types.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 25 Nov 2013 14:16:57 +0400
From:	James Bottomley <James.Bottomley@...senPartnership.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Arnd Bergmann <arnd@...db.de>, linux-arch@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0024] asm-generic: Rename int-ll64.h to types.h

On Mon, 2013-11-25 at 09:55 +0100, Geert Uytterhoeven wrote:
> This patchset aims to rename <asm-generic/int-ll64.h> to
> <asm-generic/types.h> in kernelspace, as suggested by Arnd.
> 
> While userspace still has both include/uapi/asm-generic/int-l64.h and
> include/uapi/asm-generic/int-ll64.h (int-l64.h may still be used on legacy
> 64-bit systems), kernelspace always uses "(unsigned) long long" for 64-bit
> integer values ("u64" and "s64").  Hence there's no longer a need to
> distinguish between int-l64 and int-ll64 in kernelspace, and int-ll64.h can
> just be called types.h

Is this a good idea?  I thought some versions of gcc used long long for
128 bit integers, in which case int-ll64.h will give the wrong types for
u64 and s64.  I think gcc is changing to use the __int128 type, so this
may be historical, but someone would need to validate that we have no
architectures with the old long long behaviour.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/