linux-kernel - Re: [PATCH 3.2 63/87] ext4: fix memory leak in xattr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131125190251.GA5047@redhat.com>
Date:	Mon, 25 Nov 2013 14:02:51 -0500
From:	Dave Jones <davej@...hat.com>
To:	Ben Hutchings <ben@...adent.org.uk>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	akpm@...ux-foundation.org, Eric Sandeen <sandeen@...hat.com>,
	"Theodore Ts'o" <tytso@....edu>,
	Dave Jones <davej@...oraproject.org>
Subject: Re: [PATCH 3.2 63/87] ext4: fix memory leak in xattr

On Mon, Nov 25, 2013 at 01:44:29PM +0000, Ben Hutchings wrote:
 > 3.2.53-rc1 review patch.  If anyone has any objections, please let me know.
 > 
 > --- a/fs/ext4/xattr.c
 > +++ b/fs/ext4/xattr.c
 > @@ -1269,6 +1269,8 @@ retry:
 >  				    s_min_extra_isize) {
 >  					tried_min_extra_isize++;
 >  					new_extra_isize = s_min_extra_isize;
 > +					kfree(is); is = NULL;
 > +					kfree(bs); bs = NULL;
 >  					goto retry;
 >  				}
 >  				error = -1;

There was a follow-on patch that frees the bh too.

	Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/