linux-kernel - Re: [PATCH 3.2 63/87] ext4: fix memory leak in xattr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1385437975.23855.35.camel@deadeye.wl.decadent.org.uk>
Date:	Tue, 26 Nov 2013 03:52:55 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Dave Jones <davej@...hat.com>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	akpm@...ux-foundation.org, Eric Sandeen <sandeen@...hat.com>,
	Theodore Ts'o <tytso@....edu>,
	Dave Jones <davej@...oraproject.org>
Subject: Re: [PATCH 3.2 63/87] ext4: fix memory leak in xattr

On Mon, 2013-11-25 at 14:02 -0500, Dave Jones wrote:
> On Mon, Nov 25, 2013 at 01:44:29PM +0000, Ben Hutchings wrote:
>  > 3.2.53-rc1 review patch.  If anyone has any objections, please let me know.
>  > 
>  > --- a/fs/ext4/xattr.c
>  > +++ b/fs/ext4/xattr.c
>  > @@ -1269,6 +1269,8 @@ retry:
>  >  				    s_min_extra_isize) {
>  >  					tried_min_extra_isize++;
>  >  					new_extra_isize = s_min_extra_isize;
>  > +					kfree(is); is = NULL;
>  > +					kfree(bs); bs = NULL;
>  >  					goto retry;
>  >  				}
>  >  				error = -1;
> 
> There was a follow-on patch that frees the bh too.

I've only worked through cc'd changes up to 3.12 and that one is later,
so unless you think that's urgent I'll leave it to the next update.

Ben.

-- 
Ben Hutchings
Usenet is essentially a HUGE group of people passing notes in class.
                      - Rachel Kadel, `A Quick Guide to Newsgroup Etiquette'

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)