linux-kernel - Re: [PATCH 02/16] staging/lustre/llog: MGC to use OSD API for backup logs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 26 Nov 2013 12:05:27 +0800
From:	Peng Tao <bergwolf@...il.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Mikhail Pershin <mike.pershin@...el.com>,
	Andreas Dilger <andreas.dilger@...el.com>
Subject: Re: [PATCH 02/16] staging/lustre/llog: MGC to use OSD API for backup
 logs

On 11/26/2013 11:34 AM, Greg Kroah-Hartman wrote:
> On Tue, Nov 26, 2013 at 11:25:24AM +0800, Peng Tao wrote:
>> On Tue, Nov 26, 2013 at 11:14 AM, Greg Kroah-Hartman
>> <gregkh@...uxfoundation.org> wrote:
>>> On Tue, Nov 26, 2013 at 10:04:56AM +0800, Peng Tao wrote:
>>>> From: Mikhail Pershin <mike.pershin@...el.com>
>>>>
>>>> MGC uses lvfs API to access local llogs blocking removal of old code
>>>>
>>>> - MGS is converted to use OSD API for local llogs
>>>> - llog_is_empty() and llog_backup() are introduced
>>>> - initial OSD start initialize run ctxt so llog can use it too
>>>> - shrink dcache after initial scrub in osd-ldiskfs to avoid holding
>>>>    data of unlinked objects until umount.
>>>
>>> It is not checkpatch clean :(
>>>
>>> Come on, it's not hard to do this yourself, why do you make me find
>>> these errors for you?  It does nothing but make me not want to look at
>>> lustre patches for a long time...
>>
>> Strange. I did run checkpatch before sending the patchset out.
>>
>> Just tried again. Still pass.
>>
>> [X61@...ux-lustre]$./scripts/checkpatch.pl
>> 0002-staging-lustre-llog-MGC-to-use-OSD-API-for-backup-lo.patch total:
>> 0 errors, 0 warnings, 883 lines checked
>>
>> 0002-staging-lustre-llog-MGC-to-use-OSD-API-for-backup-lo.patch has no
>> obvious style problems and is ready for submission.
>>
>> What message did you see?
>
> One about return();
>
OK. Looks like a latest checkpatch.pl change. After rebasing my working 
copy to latest staging-next, I can see the same error. I'll fix up. 
Sorry for the noise.

Thanks,
Tao





View attachment "0002-staging-lustre-llog-MGC-to-use-OSD-API-for-backup-lo.patch" of type "text/x-patch" (29487 bytes)