linux-kernel - [PATCHv2] perf tools: Fix tags/TAGS targets rebuilding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131126125412.GJ1267@krava.brq.redhat.com>
Date:	Tue, 26 Nov 2013 13:54:12 +0100
From:	Jiri Olsa <jolsa@...hat.com>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	linux-kernel@...r.kernel.org,
	Frederic Weisbecker <fweisbec@...il.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Mike Galbraith <efault@....de>,
	Stephane Eranian <eranian@...gle.com>,
	David Ahern <dsahern@...il.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Arnaldo Carvalho de Melo <acme@...hat.com>
Subject: [PATCHv2] perf tools: Fix tags/TAGS targets rebuilding

On Tue, Nov 26, 2013 at 01:00:55PM +0100, Ingo Molnar wrote:
> 
> * Jiri Olsa <jolsa@...hat.com> wrote:
> 
> > On Tue, Nov 26, 2013 at 12:31:08PM +0100, Ingo Molnar wrote:

SNIP

> > > 
> > > Also note that we have duplicate code for this in Makefile.perf 
> > > already. Would it be possible to pass through this there and keep the 
> > > main Makefile is just a thin, minimal wrapper that adds default 
> > > parallelism, etc?
> > 
> > well, thats what I actually tried to do.. pass the
> > processing to the Makefile.perf otherwise it stops
> > in Makefile
> > 
> > I guess you want some generic way of doing that
> 
> If it's just these two phony targets that need to be in the main 
> makefile then I guess your approach is the simplest one and we should 
> do it like that instead of complicating the interface. If it gets 
> messier in the future we can reconsider?
> 

sounds good, pelase check v2

thanks,
jirka


---
Once the tags/TAGS file is generated it's never rebuilt
until it's removed by hand.

The reason is that the Makefile does not treat tags/TAGS
as targets but as files and thus won't rebuilt them
once they are in place.

Adding PHONY tags/TAGS targets into Makefile.

Signed-off-by: Jiri Olsa <jolsa@...hat.com>
Cc: Ingo Molnar <mingo@...nel.org>
Cc: Frederic Weisbecker <fweisbec@...il.com>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Namhyung Kim <namhyung@...nel.org>
Cc: Mike Galbraith <efault@....de>
Cc: Stephane Eranian <eranian@...gle.com>
Cc: David Ahern <dsahern@...il.com>
Cc: Adrian Hunter <adrian.hunter@...el.com>
Cc: Arnaldo Carvalho de Melo <acme@...hat.com>
---
 tools/perf/Makefile | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/tools/perf/Makefile b/tools/perf/Makefile
index 4835618..eefb9fb 100644
--- a/tools/perf/Makefile
+++ b/tools/perf/Makefile
@@ -60,8 +60,11 @@ endef
 
 #
 # Needed if no target specified:
+# (Except for tags and TAGS targets. The reason is that the
+# Makefile does not treat tags/TAGS as targets but as files
+# and thus won't rebuilt them once they are in place.)
 #
-all:
+all tags TAGS:
	$(print_msg)
	$(make)
 
@@ -77,3 +80,5 @@ clean:
 %:
	$(print_msg)
	$(make)
+
+.PHONY: tags TAGS
-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/