linux-kernel - Re: [PATCH] dmaengine: at_hdmac: remove unused function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 27 Nov 2013 10:55:13 +0100
From:	Nicolas Ferre <nicolas.ferre@...el.com>
To:	Olof Johansson <olof@...om.net>,
	Dan Williams <dan.j.williams@...el.com>
CC:	Kyungmin Park <kyungmin.park@...sung.com>,
	<dmaengine@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Subject: Re: [PATCH] dmaengine: at_hdmac: remove unused function

On 26/11/2013 19:43, Olof Johansson :
> commit 54f8d501e8428 ('dmaengine: remove DMA unmap from drivers')
> refactored some code which resulted in an unused function in the at_hdmac
> driver:
>
> drivers/dma/at_hdmac_regs.h:350:23: warning: 'chan2parent' defined but
>      not used [-Wunused-function]
>
> Fixes: 54f8d501e8428 ('dmaengine: remove DMA unmap from drivers')
> Signed-off-by: Olof Johansson <olof@...om.net>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>

Indeed,

Acked-by: Nicolas Ferre <nicolas.ferre@...el.com>

Thanks Olof for having taken care of this.

Bye,

> ---
>
> Dan,
>
> Looks like you fixed up the DesignWare driver for the same issue but
> this needs it to.
>
>   drivers/dma/at_hdmac_regs.h | 4 ----
>   1 file changed, 4 deletions(-)
>
> diff --git a/drivers/dma/at_hdmac_regs.h b/drivers/dma/at_hdmac_regs.h
> index f31d647acdfa..2787aba60c6b 100644
> --- a/drivers/dma/at_hdmac_regs.h
> +++ b/drivers/dma/at_hdmac_regs.h
> @@ -347,10 +347,6 @@ static struct device *chan2dev(struct dma_chan *chan)
>   {
>   	return &chan->dev->device;
>   }
> -static struct device *chan2parent(struct dma_chan *chan)
> -{
> -	return chan->dev->device.parent;
> -}
>
>   #if defined(VERBOSE_DEBUG)
>   static void vdbg_dump_regs(struct at_dma_chan *atchan)
>


-- 
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/