linux-kernel - Re: [PATCH] dmaengine: at_hdmac: remove unused function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 27 Nov 2013 11:54:56 +0100
From:	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:	Olof Johansson <olof@...om.net>
Cc:	Dan Williams <dan.j.williams@...el.com>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	dmaengine@...r.kernel.org, nicolas.ferre@...el.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dmaengine: at_hdmac: remove unused function


Hi Olof,

On Tuesday, November 26, 2013 10:43:35 AM Olof Johansson wrote:
> commit 54f8d501e8428 ('dmaengine: remove DMA unmap from drivers')
> refactored some code which resulted in an unused function in the at_hdmac
> driver:
> 
> drivers/dma/at_hdmac_regs.h:350:23: warning: 'chan2parent' defined but
>     not used [-Wunused-function]
> 
> Fixes: 54f8d501e8428 ('dmaengine: remove DMA unmap from drivers')
> Signed-off-by: Olof Johansson <olof@...om.net>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>

Thanks for catching and fixing this.

Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

> ---
> 
> Dan,
> 
> Looks like you fixed up the DesignWare driver for the same issue but
> this needs it to.
> 
>  drivers/dma/at_hdmac_regs.h | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/dma/at_hdmac_regs.h b/drivers/dma/at_hdmac_regs.h
> index f31d647acdfa..2787aba60c6b 100644
> --- a/drivers/dma/at_hdmac_regs.h
> +++ b/drivers/dma/at_hdmac_regs.h
> @@ -347,10 +347,6 @@ static struct device *chan2dev(struct dma_chan *chan)
>  {
>  	return &chan->dev->device;
>  }
> -static struct device *chan2parent(struct dma_chan *chan)
> -{
> -	return chan->dev->device.parent;
> -}
>  
>  #if defined(VERBOSE_DEBUG)
>  static void vdbg_dump_regs(struct at_dma_chan *atchan)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/