linux-kernel - RE: [PATCH] crypto: remove unnecessary includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 29 Nov 2013 12:07:07 +0000
From:	Cristian Stoica <cristian.stoica@...escale.com>
To:	Herbert Xu <herbert@...dor.apana.org.au>
CC:	"linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] crypto: remove unnecessary includes

> On Fri, Nov 29, 2013 at 08:49:42AM +0000, Cristian Stoica wrote:
> > >From what I could see there is nothing from those includes that is
> used inside authenc.c.
> > The build passes without them.
> 
> Just because it compiles it doesn't meant that the files you
> removed are unnecessary.
> 
> The only file that is really unnecessary here is spinlock.h.
> 
[] 
OK then, but let's reverse the question. In a construct similar to authenc.c, what would be the purpose of slab.h and kernel.h?
(That leads to the next question which is - what is the purpose of those files in authenc.c?)

Thanks,
Cristian S.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/