linux-kernel - RE: [PATCH] crypto: remove unnecessary includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1628287275CAA9409F1E349DEF3C6CCE78CBF0@039-SN2MPN1-012.039d.mgd.msft.net>
Date:	Thu, 5 Dec 2013 08:14:55 +0000
From:	Cristian Stoica <cristian.stoica@...escale.com>
To:	Cristian Stoica <cristian.stoica@...escale.com>,
	Herbert Xu <herbert@...dor.apana.org.au>
CC:	"linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] crypto: remove unnecessary includes

Hi Herbert,

Your original response was terse and left me more puzzled. Do you have a sensible explanation why some includes should be kept in the source even they serve no purpose during the build?

Thanks,

Cristian S.



> > Just because it compiles it doesn't meant that the files you
> > removed are unnecessary.
> >
> > The only file that is really unnecessary here is spinlock.h.
> >
> []
> OK then, but let's reverse the question. In a construct similar to
> authenc.c, what would be the purpose of slab.h and kernel.h?
> (That leads to the next question which is - what is the purpose of those
> files in authenc.c?)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/