linux-kernel - Re: Some kernel module options not showing up in modinfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87k3fpfsbo.fsf@rustcorp.com.au>
Date:	Sun, 01 Dec 2013 08:46:59 +1030
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Raphael Hertzog <hertzog@...ian.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: Some kernel module options not showing up in modinfo

Raphael Hertzog <hertzog@...ian.org> writes:
> Hi,
>
> On Fri, 22 Nov 2013, Rusty Russell wrote:
>> Raphael Hertzog <hertzog@...ian.org> writes:
>> > Hello,
>> >
>> > I noticed that some options are not visible in the modinfo output. For
>> > instance "modinfo lockd" reports this on my Debian sid system:
> [...]
>> > Multiple other options are defined by way of module_param_call(...) like
>> > nlm_grace_period, nlm_timeout, nlm_updport, nlm_tcpport.
>> 
>> Yes, the module_param() macro adds a type description.  The
>> module_param_call() does not.
>
> Couldn't they be displayed without any type or with a type "unknown" ?
>
> parm: nlm_grace_period
>
> or 
>
> parm: nlm_grace_period:unknown

The type thing is really a hack.  Ideally we should force documentation
on everyone who declares a module parameter with a new macro we can
transition to.

Of course, most descriptions would be incoherent, a-la Kbuild help
messages, so we'd need an enforcer...

Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/