linux-kernel - Re: [PATCH] omap: twl-common: Fix musb-hdrc device name.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 3 Dec 2013 14:28:43 +0530
From:	Kishon Vijay Abraham I <kishon@...com>
To:	Marek Belisko <marek.belisko@...n-nandra.com>, <tony@...mide.com>,
	<linux@....linux.org.uk>
CC:	<linux-arm-kernel@...ts.infradead.org>,
	<linux-omap@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<hns@...delico.com>
Subject: Re: [PATCH] omap: twl-common: Fix musb-hdrc device name.

Hi,

On Tuesday 03 December 2013 02:03 PM, Marek Belisko wrote:
> Without this change when booting omap3 device (gta04) with board file
> leads to follwing errors:
> 
> [    1.203308] musb-hdrc musb-hdrc.0.auto: unable to find phy
> [    1.209075] HS USB OTG: no transceiver configured
> [    1.214019] musb-hdrc musb-hdrc.0.auto: musb_init_controller failed with status -517
> 
> and usb isn't working.
> 
> This is probably regression caused by commit: 6c27f939

I think a better fix would be to have this merged..
https://lkml.org/lkml/2013/7/26/91
> 
> Signed-off-by: Marek Belisko <marek.belisko@...n-nandra.com>
> ---
>  arch/arm/mach-omap2/twl-common.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-omap2/twl-common.c b/arch/arm/mach-omap2/twl-common.c
> index b0d54da..3640ce0 100644
> --- a/arch/arm/mach-omap2/twl-common.c
> +++ b/arch/arm/mach-omap2/twl-common.c
> @@ -92,7 +92,7 @@ void __init omap_pmic_late_init(void)
>  
>  #if defined(CONFIG_ARCH_OMAP3)
>  struct phy_consumer consumers[] = {
> -	PHY_CONSUMER("musb-hdrc.0", "usb"),
> +	PHY_CONSUMER("musb-hdrc.0.auto", "usb"),

the index '0' might vary for some boards leading it to again break musb.

Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/