linux-kernel - Re: [PATCH] omap: twl-common: Fix musb-hdrc device name.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAfyv37Vie1vZK2XQ1cfVq6eVnSuaBLfykk6pU8fwEyqvPF4BA@mail.gmail.com>
Date:	Tue, 3 Dec 2013 10:08:38 +0100
From:	Belisko Marek <marek.belisko@...il.com>
To:	Kishon Vijay Abraham I <kishon@...com>
Cc:	Tony Lindgren <tony@...mide.com>,
	Russell King - ARM Linux <linux@....linux.org.uk>,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"Dr. H. Nikolaus Schaller" <hns@...delico.com>
Subject: Re: [PATCH] omap: twl-common: Fix musb-hdrc device name.

Hi,

On Tue, Dec 3, 2013 at 9:58 AM, Kishon Vijay Abraham I <kishon@...com> wrote:
> Hi,
>
> On Tuesday 03 December 2013 02:03 PM, Marek Belisko wrote:
>> Without this change when booting omap3 device (gta04) with board file
>> leads to follwing errors:
>>
>> [    1.203308] musb-hdrc musb-hdrc.0.auto: unable to find phy
>> [    1.209075] HS USB OTG: no transceiver configured
>> [    1.214019] musb-hdrc musb-hdrc.0.auto: musb_init_controller failed with status -517
>>
>> and usb isn't working.
>>
>> This is probably regression caused by commit: 6c27f939
>
> I think a better fix would be to have this merged..
> https://lkml.org/lkml/2013/7/26/91
Yes I see but how this could help with current situation? Ho you then
specify device number?
This patch is fixing 3.13-rcx regression.

>>
>> Signed-off-by: Marek Belisko <marek.belisko@...n-nandra.com>
>> ---
>>  arch/arm/mach-omap2/twl-common.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/mach-omap2/twl-common.c b/arch/arm/mach-omap2/twl-common.c
>> index b0d54da..3640ce0 100644
>> --- a/arch/arm/mach-omap2/twl-common.c
>> +++ b/arch/arm/mach-omap2/twl-common.c
>> @@ -92,7 +92,7 @@ void __init omap_pmic_late_init(void)
>>
>>  #if defined(CONFIG_ARCH_OMAP3)
>>  struct phy_consumer consumers[] = {
>> -     PHY_CONSUMER("musb-hdrc.0", "usb"),
>> +     PHY_CONSUMER("musb-hdrc.0.auto", "usb"),
>
> the index '0' might vary for some boards leading it to again break musb.
If you run grep for musb-hdrc :
arch/arm/mach-omap2/board-3430sdp.c: usb_bind_phy("musb-hdrc.0.auto",
0, "twl4030_usb");
arch/arm/mach-omap2/board-devkit8000.c:
usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb");
arch/arm/mach-omap2/board-overo.c: usb_bind_phy("musb-hdrc.0.auto", 0,
"twl4030_usb");
arch/arm/mach-omap2/board-omap3beagle.c:
usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb");
arch/arm/mach-omap2/board-omap3touchbook.c:
usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb");
arch/arm/mach-omap2/board-cm-t35.c: usb_bind_phy("musb-hdrc.0.auto",
0, "twl4030_usb");
arch/arm/mach-omap2/board-omap3stalker.c:
usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb");
arch/arm/mach-omap2/board-omap3logic.c:
usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb");
arch/arm/mach-omap2/board-2430sdp.c: usb_bind_phy("musb-hdrc.0.auto",
0, "twl4030_usb");
arch/arm/mach-omap2/board-ldp.c: usb_bind_phy("musb-hdrc.0.auto", 0,
"twl4030_usb");
arch/arm/mach-omap2/board-rx51.c: usb_bind_phy("musb-hdrc.0.auto", 0,
"twl4030_usb");
arch/arm/mach-omap2/board-omap3pandora.c:
usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb");

Until mentioned patch isn't merged and PHY_CONSUMER isn't updated I
think this is correct solution.
>
> Thanks
> Kishon

BR,

marek

-- 
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/