| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <529D3627.1000205@huawei.com> Date: Tue, 3 Dec 2013 09:38:47 +0800 From: Rui Xiang <rui.xiang@...wei.com> To: Greg Kroah-Hartman <gregkh@...uxfoundation.org> CC: <linux-kernel@...r.kernel.org> Subject: [PATCH] sysfs: add necessary Null check in sysfs_do_create_link_sd While target_sd or sd are null, it won't need sysfs_put and should return -ENOENT directly. Here add null check for target_sd and sd. Signed-off-by: Rui Xiang <rui.xiang@...wei.com> --- fs/sysfs/symlink.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/sysfs/symlink.c b/fs/sysfs/symlink.c index 3ae3f1b..d69b786 100644 --- a/fs/sysfs/symlink.c +++ b/fs/sysfs/symlink.c @@ -83,8 +83,10 @@ static int sysfs_do_create_link_sd(struct sysfs_dirent *parent_sd, return 0; out_put: - sysfs_put(target_sd); - sysfs_put(sd); + if (target_sd) + sysfs_put(target_sd); + if (sd) + sysfs_put(sd); return error; } -- 1.8.2.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists