linux-kernel - Re: [Xen-devel] [PATCH] xen/block: Correctly define structures in public headers on ARM32 and ARM64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1386085745.13256.51.camel@kazak.uk.xensource.com>
Date:	Tue, 3 Dec 2013 15:49:05 +0000
From:	Ian Campbell <Ian.Campbell@...rix.com>
To:	Julien Grall <julien.grall@...aro.org>
CC:	Jan Beulich <JBeulich@...e.com>,
	David Vrabel <david.vrabel@...rix.com>,
	Roger Pau Monne <roger.pau@...rix.com>,
	Stefano Stabellini <stefano.stabellini@...citrix.com>,
	<patches@...aro.org>, <linux-arm-kernel@...ts.infradead.org>,
	<xen-devel@...ts.xenproject.org>,
	"Boris Ostrovsky" <boris.ostrovsky@...cle.com>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [Xen-devel] [PATCH] xen/block: Correctly define structures in
 public headers on ARM32 and ARM64

On Tue, 2013-12-03 at 15:28 +0000, Julien Grall wrote:
> On 12/03/2013 03:15 PM, Jan Beulich wrote:
> >>>> On 03.12.13 at 16:09, Julien Grall <julien.grall@...aro.org> wrote:
> >> --- a/include/xen/interface/io/blkif.h
> >> +++ b/include/xen/interface/io/blkif.h
> >> @@ -146,7 +146,7 @@ struct blkif_request_segment_aligned {
> >>  struct blkif_request_rw {
> >>  	uint8_t        nr_segments;  /* number of segments                   */
> >>  	blkif_vdev_t   handle;       /* only for read/write requests         */
> >> -#ifdef CONFIG_X86_64
> >> +#if defined(CONFIG_X86_64) || defined(CONFIG_ARM) || defined(CONFIG_ARM64)
> > 
> > Perhaps using
> > 
> > #ifndef CONFIG_X86_32
> > 
> > would be the better one, assuming that we won't add further
> > non-64-bit-clean ABI variants?
> 
> I'm fine with this solution. I will resend the patch.

Just a random thought but what about using the CONFIG_$ARCH to define a
more semantic name, like HAVE_4_BYTE_ALIGNED_QUAD_WORDS, or whichever
terminology for an 8-byte type is appropriate in the context.

Maybe Linux even already has such a #define?

Ian.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/