linux-kernel - Re: [PATCH V4] dma: add dma_get_any_slave_channel(), for use in of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <529E19E7.8090402@wwwdotorg.org>
Date:	Tue, 03 Dec 2013 10:50:31 -0700
From:	Stephen Warren <swarren@...dotorg.org>
To:	Dan Williams <dan.j.williams@...el.com>,
	Vinod Koul <vinod.koul@...el.com>
CC:	dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org,
	Stephen Warren <swarren@...dia.com>,
	Lars-Peter Clausen <lars@...afoo.de>
Subject: Re: [PATCH V4] dma: add dma_get_any_slave_channel(), for use in of_xlate()

On 11/26/2013 12:40 PM, Stephen Warren wrote:
> From: Stephen Warren <swarren@...dia.com>
> 
> mmp_pdma.c implements a custom of_xlate() function that is 95% identical
> to what Tegra will need. Create a function to implement the common part,
> so everyone doesn't just cut/paste the implementation.
> 
> Cc: Dan Williams <dan.j.williams@...el.com>
> Cc: Vinod Koul <vinod.koul@...el.com>
> Cc: Lars-Peter Clausen <lars@...afoo.de>
> Cc: dmaengine@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> Signed-off-by: Stephen Warren <swarren@...dia.com>
> ---
> v3:
> * Re-implemented the common code as dma_get_any_slave_channel(), in
>   dmaengine.c. This allows it to mutex_lock(&dma_list_mutex), and hence
>   avoid the retry loop.
> * Rather than having the common code call out to a driver-provided
>   callback at the tail (which avoided drivers having to implement an
>   of_xlate function themselves), have drivers implement a custom
>   of_xlate() again, which mostly just calls the new
>   dma_get_any_slave_channel(), then does any extra custom work.
> 
> v2:
> * Squashed the conversion of mmp_pdma.c into the patch that added the
>   common implementation, so it's easier to see the whole conversion in
>   one go.
> 
> This patch is a dependency for a series that reworks many of the Tegra
> drivers.
> 
> As such, it needs to go into a topic branch on its own, based directly
> on 3.13-rc1. If the DMA maintainers ack the patches I'm happy to create
> this topic branch myself and send a pull request to the DMA tree. Or the
> patches can be applied to a topic branch by the DMA maintainers and I
> will merge their topic branch into the Tegra rework branch that I
> mentioned.
> 
> Note that this patch is independant from the "dma: add channel request
> API that supports deferred probe" which I just sent, so it could
> (should?) be a different topic branch.

Vinod, does this patch look OK to you? Are you able to stage it into a
topic branch that I can pull into the Tegra tree as a dependency?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/