linux-kernel - Re: [PATCH V2 1/2] ARM: tegra: Add header file for pinctrl constants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 4 Dec 2013 09:20:24 +0100
From:	Thierry Reding <thierry.reding@...il.com>
To:	Laxman Dewangan <ldewangan@...dia.com>
Cc:	rob.herring@...xeda.com, swarren@...dotorg.org, pawel.moll@....com,
	mark.rutland@....com, ijc+devicetree@...lion.org.uk,
	linux@....linux.org.uk, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-tegra@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 1/2] ARM: tegra: Add header file for pinctrl constants

On Tue, Dec 03, 2013 at 06:46:06PM +0530, Laxman Dewangan wrote:
> This new header file defines pincontrol constants for Tegra to
> use from Tegra's DTS file for pincontrol properties option.
> 
> Signed-off-by: Laxman Dewangan <ldewangan@...dia.com>
> ---
> Changes from V1:
> - Get rid of lots of macro and converge it to TEGRA_PIN_ENABLE/DISABLE.
> - Change macro name for PULL UP/DOWN/NONE.
> 
>  include/dt-bindings/pinctrl/pinctrl-tegra.h |   40 +++++++++++++++++++++++++++
>  1 files changed, 40 insertions(+), 0 deletions(-)
>  create mode 100644 include/dt-bindings/pinctrl/pinctrl-tegra.h

I like this a lot. One minor nit below.

> diff --git a/include/dt-bindings/pinctrl/pinctrl-tegra.h b/include/dt-bindings/pinctrl/pinctrl-tegra.h
> new file mode 100644
> index 0000000..e5f02f8
> --- /dev/null
> +++ b/include/dt-bindings/pinctrl/pinctrl-tegra.h
> @@ -0,0 +1,40 @@
> +/*
> + * This header provides constants for TEGRA pinctrl bindings.

"TEGRA" -> "Tegra"

Other than that:

Reviewed-by: Thierry Reding <treding@...dia.com>

Content of type "application/pgp-signature" skipped