linux-kernel - Re: [PATCH V2 1/2] ARM: tegra: Add header file for pinctrl constants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <529F6064.3010300@wwwdotorg.org>
Date:	Wed, 04 Dec 2013 10:03:32 -0700
From:	Stephen Warren <swarren@...dotorg.org>
To:	Laxman Dewangan <ldewangan@...dia.com>, rob.herring@...xeda.com
CC:	pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, linux@....linux.org.uk,
	thierry.reding@...il.com, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-tegra@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 1/2] ARM: tegra: Add header file for pinctrl constants

On 12/03/2013 06:16 AM, Laxman Dewangan wrote:
> This new header file defines pincontrol constants for Tegra to
> use from Tegra's DTS file for pincontrol properties option.

> diff --git a/include/dt-bindings/pinctrl/pinctrl-tegra.h b/include/dt-bindings/pinctrl/pinctrl-tegra.h

> +#define TEGRA_PIN_DISABLE				0
> +#define TEGRA_PIN_ENABLE				1

That needs a comment re: which properties the defines can be used with,
since the properties are no longer related to the defines by name.

> +/* Pull up/down/normal */
> +#define TEGRA_PIN_PULL_NONE				0
> +#define TEGRA_PIN_PULL_DOWN				1
> +#define TEGRA_PIN_PULL_UP				2

Whereas that comment seems unnecessary, since it's obvious from the
define names.

> +/* Low power mode */
> +#define TEGRA_PIN_LP_DRIVE_DIV_8			0
> +#define TEGRA_PIN_LP_DRIVE_DIV_4			1
> +#define TEGRA_PIN_LP_DRIVE_DIV_2			2
> +#define TEGRA_PIN_LP_DRIVE_DIV_1			3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/