linux-kernel - Re: [PATCH v4 2/3] perf diff: color the Ratio column

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131204125904.GB6359@ghostprotocols.net>
Date:	Wed, 4 Dec 2013 09:59:04 -0300
From:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
To:	Ramkumar Ramachandra <artagnon@...il.com>
Cc:	Jiri Olsa <jolsa@...hat.com>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 2/3] perf diff: color the Ratio column

Em Wed, Dec 04, 2013 at 03:40:25PM +0530, Ramkumar Ramachandra escreveu:
> Arnaldo Carvalho de Melo wrote:
> > static inline percent_color_snprintf(...)
> > {
> >         return value_color_snprintf(...);
> > }
> 
> The issue with this suggestion is that the prototype of
> percent_color_snprintf() is:
> 
>   int percent_color_snprintf(char *bf, size_t size, const char *fmt, ...)
> 
> So, I can only pass value_color_snprintf() a va_list, making its prototype:
> 
>   int value_color_snprintf(char *bf, size_t size, const char *fmt, va_list args)
> 
> Is this worth the minor rename?

That is ok, I'd say. Or if that would be a problem one could consider
using a macro, perhaps.
 
> On a related note, does percent_color_snprintf() need to be a variadic
> function? It only seems to process one percent value.

I think that there are places where it is passed as a pointer that
expects it to have that prototype, this is from memory, so please check.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/