linux-kernel - [patch] fix n900 bt error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131205115608.GA9498@amd.pavel.ucw.cz>
Date:	Thu, 5 Dec 2013 12:56:08 +0100
From:	Pavel Machek <pavel@....cz>
To:	Pali Rohár <pali.rohar@...il.com>
Cc:	Sebastian Reichel <sre@...ian.org>,
	kernel list <linux-kernel@...r.kernel.org>
Subject: [patch] fix n900 bt error handling

Hi!

> I think that we can drop "new" version, because it has several
> problems and "old" version is working. So now it not make sense
> to use hack or develop "new" version anymore.

Ok... but this seems still needed. Please apply,
							Pavel

commit 6c65774280a7095dce8b1e995d86b2e079ef5fdb
Author: Pavel <pavel@....cz>
Date:   Thu Dec 5 12:54:31 2013 +0100

Cleanups should be performed even if firmware load fails.
   
Signed-off-by: Pavel Machek <pavel@....cz>

diff --git a/drivers/bluetooth/hci_h4p/core.c b/drivers/bluetooth/hci_h4p/core.c
index ead25c4..e76e889 100644
--- a/drivers/bluetooth/hci_h4p/core.c
+++ b/drivers/bluetooth/hci_h4p/core.c
@@ -942,7 +942,7 @@ again:
 	err = hci_h4p_read_fw(info, &fw_queue);
 	if (err < 0) {
 		dev_err(info->dev, "Cannot read firmware\n");
-		return err;
+		goto err_clean;
 	}
 
 	err = hci_h4p_send_fw(info, &fw_queue);



-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/