linux-kernel - Re: [patch] fix n900 bt error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201312051408.30330@pali>
Date:	Thu, 5 Dec 2013 14:08:28 +0100
From:	Pali Rohár <pali.rohar@...il.com>
To:	Pavel Machek <pavel@....cz>
Cc:	Sebastian Reichel <sre@...ian.org>,
	kernel list <linux-kernel@...r.kernel.org>
Subject: Re: [patch] fix n900 bt error handling

On Thursday 05 December 2013 12:56:08 Pavel Machek wrote:
> Hi!
> 
> > I think that we can drop "new" version, because it has
> > several problems and "old" version is working. So now it
> > not make sense to use hack or develop "new" version
> > anymore.
> 
> Ok... but this seems still needed. Please apply,
> 							Pavel
> 
> commit 6c65774280a7095dce8b1e995d86b2e079ef5fdb
> Author: Pavel <pavel@....cz>
> Date:   Thu Dec 5 12:54:31 2013 +0100
> 
> Cleanups should be performed even if firmware load fails.
> 
> Signed-off-by: Pavel Machek <pavel@....cz>
> 
> diff --git a/drivers/bluetooth/hci_h4p/core.c
> b/drivers/bluetooth/hci_h4p/core.c index ead25c4..e76e889
> 100644
> --- a/drivers/bluetooth/hci_h4p/core.c
> +++ b/drivers/bluetooth/hci_h4p/core.c
> @@ -942,7 +942,7 @@ again:
>  	err = hci_h4p_read_fw(info, &fw_queue);
>  	if (err < 0) {
>  		dev_err(info->dev, "Cannot read firmware\n");
> -		return err;
> +		goto err_clean;
>  	}
> 
>  	err = hci_h4p_send_fw(info, &fw_queue);

Done, pushed to 3.12-rc5-n900 and 3.13-rc2-n900 branches.

-- 
Pali Rohár
pali.rohar@...il.com

Download attachment "signature.asc " of type "application/pgp-signature" (199 bytes)