linux-kernel - Re: [PATCH v2 4/5] fat: fallback to buffered write in case of fallocatded region on direct IO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKYAXd8vXgG-n1f7Mm73+i_BPR+AaQt6H0cMG0kZZxS00y6=zw@mail.gmail.com>
Date:	Thu, 5 Dec 2013 23:16:44 +0900
From:	Namjae Jeon <linkinjeon@...il.com>
To:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
Cc:	akpm@...ux-foundation.org, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Namjae Jeon <namjae.jeon@...sung.com>,
	Amit Sahrawat <a.sahrawat@...sung.com>
Subject: Re: [PATCH v2 4/5] fat: fallback to buffered write in case of
 fallocatded region on direct IO

2013/12/1, OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>:
> Namjae Jeon <linkinjeon@...il.com> writes:
>
>> diff --git a/fs/fat/inode.c b/fs/fat/inode.c
>> index 12a37a9..c9fb9b6 100644
>> --- a/fs/fat/inode.c
>> +++ b/fs/fat/inode.c
>> @@ -217,6 +217,14 @@ static ssize_t fat_direct_IO(int rw, struct kiocb
>> *iocb,
>>  		loff_t size = offset + iov_iter_count(iter);
>>  		if (MSDOS_I(inode)->mmu_private < size)
>>  			return 0;
>> +
>> +		/*
>> +		 * In case of writing in fallocated region, return 0 and
>> +		 * fallback to buffered write.
>> +		 */
>> +		if (MSDOS_I(inode)->i_disksize >
>> +		    round_up(i_size_read(inode), inode->i_sb->s_blocksize))
>> +			return 0;
>
> ->mmu_private works instead of i_size?
Yes, I will change it.
Thanks.
> --
> OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/