linux-kernel - Re: [PATCH 4/6] regulator: gpio-regulator: use devm_regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131206120907.GE29268@sirena.org.uk>
Date:	Fri, 6 Dec 2013 12:09:07 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Heiko Stübner <heiko@...ech.de>
Cc:	Jingoo Han <jg1.han@...sung.com>,
	'Liam Girdwood' <lgirdwood@...il.com>,
	linux-kernel@...r.kernel.org, 'Axel Lin' <axel.lin@...ics.com>
Subject: Re: [PATCH 4/6] regulator: gpio-regulator: use
 devm_regulator_register()

On Fri, Dec 06, 2013 at 10:12:05AM +0100, Heiko Stübner wrote:

> I'm not this firm in the core driver/device behaviour, but when looking at 
> __device_release_driver I see that the remove callback runs before 
> devres_release_all, which would effectively free the gpios before the 
> regulator gets unregistered - is this racy with a regulator change at the same 
> time?

Yes, the rest of the driver really needs to be converted to devm_ at the
same time.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)