linux-kernel - Re: [PATCH 4/6] regulator: gpio-regulator: use devm_regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <001401cef482$90461180$b0d23480$%han@samsung.com>
Date:	Mon, 09 Dec 2013 11:01:24 +0900
From:	Jingoo Han <jg1.han@...sung.com>
To:	'Mark Brown' <broonie@...nel.org>,
	'Heiko Stübner' <heiko@...ech.de>
Cc:	'Liam Girdwood' <lgirdwood@...il.com>,
	linux-kernel@...r.kernel.org, 'Axel Lin' <axel.lin@...ics.com>,
	'Jingoo Han' <jg1.han@...sung.com>
Subject: Re: [PATCH 4/6] regulator: gpio-regulator: use
 devm_regulator_register()

On Friday, December 06, 2013 9:09 PM, Mark Brown wrote:
> On Fri, Dec 06, 2013 at 10:12:05AM +0100, Heiko Stübner wrote:
> 
> > I'm not this firm in the core driver/device behaviour, but when looking at
> > __device_release_driver I see that the remove callback runs before
> > devres_release_all, which would effectively free the gpios before the
> > regulator gets unregistered - is this racy with a regulator change at the same
> > time?
> 
> Yes, the rest of the driver really needs to be converted to devm_ at the
> same time.

The gpios is requested by gpio_request_array().
However, devm_gpio_request_array() is not supported yet,
so the rest of the driver cannot be converted to devm_.

Mark Brown,
Please ignore this patch.

Best regards,
Jingoo Han

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/