linux-kernel - Re: [PATCH 2/2] perf: unwinding: use the per-feature check flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131209171719.GA16631@krava.brq.redhat.com>
Date:	Mon, 9 Dec 2013 18:17:19 +0100
From:	Jiri Olsa <jolsa@...hat.com>
To:	Jean Pihet <jean.pihet@...aro.org>
Cc:	linux-kernel@...r.kernel.org, linaro-kernel@...ts.linaro.org,
	Ingo Molnar <mingo@...nel.org>,
	Arnaldo <acme@...stprotocols.net>,
	Will Deacon <will.deacon@....com>, patches@...aro.org
Subject: Re: [PATCH 2/2] perf: unwinding: use the per-feature check flags

On Sat, Dec 07, 2013 at 11:17:41AM +0100, Jean Pihet wrote:
> Use the per-feature check flags for the unwinding feature in order
> to correctly compile the libunwind and libunwind-debug-frame feature
> checks.
> 
> Tested on x86_64, ARMv7 and ARMv8 with and without LIBUNWIND_DIR set
> in 'make -C tools/perf'
> 
> Signed-off-by: Jean Pihet <jean.pihet@...aro.org>
> Cc: Jiri Olsa <jolsa@...hat.com>

SNIP

> +BUILD = $(CC) $(CFLAGS) -o $(OUTPUT)$@ $@.c $(LDFLAGS)
>  
>  ###############################
>  
>  test-all:
> -	$(BUILD) -Werror -fstack-protector -fstack-protector-all -O2 -Werror -D_FORTIFY_SOURCE=2 -ldw -lelf -lnuma $(LIBUNWIND_LIBS) -lelf -laudit -I/usr/include/slang -lslang $(shell pkg-config --libs --cflags gtk+-2.0 2>/dev/null) $(FLAGS_PERL_EMBED) $(FLAGS_PYTHON_EMBED) -DPACKAGE='"perf"' -lbfd -ldl
> +	$(BUILD) -Werror -fstack-protector -fstack-protector-all -O2 -Werror -D_FORTIFY_SOURCE=2 -ldw -lelf -lnuma -lelf -laudit -I/usr/include/slang -lslang $(shell pkg-config --libs --cflags gtk+-2.0 2>/dev/null) $(FLAGS_PERL_EMBED) $(FLAGS_PYTHON_EMBED) -DPACKAGE='"perf"' -lbfd -ldl

hum, the test-all build command should have every possible flags we use, right?
including LIBUNWIND_CFLAGS, LIBUNWIND_LDFLAGS

also, this patch no longer applies on acme's perf/core

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/