[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <52A619A3.7020705@infradead.org>
Date: Mon, 09 Dec 2013 11:27:31 -0800
From: Randy Dunlap <rdunlap@...radead.org>
To: balbi@...com
CC: USB list <linux-usb@...r.kernel.org>,
LKML <linux-kernel@...r.kernel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Andrzej Pietrasiewicz <andrzej.p@...sung.com>
Subject: Re: [PATCH] gadget: make USB_CONFIGFS_MASS_STORAGE depend on BLOCK
On 12/09/13 11:21, Felipe Balbi wrote:
> On Mon, Dec 09, 2013 at 11:18:25AM -0800, Randy Dunlap wrote:
>> From: Randy Dunlap <rdunlap@...radead.org>
>>
>> Make USB_CONFIGFS_MASS_STORAGE depend on BLOCK just like the other
>> gadget MASS_STORAGE options do. This fixes the following build errors
>> that occur when BLOCK is not enabled:
>>
>> drivers/usb/gadget/storage_common.c: In function 'fsg_lun_open':
>> drivers/usb/gadget/storage_common.c:241:3: error: implicit declaration of function 'bdev_logical_block_size' [-Werror=implicit-function-declaration]
>> drivers/usb/gadget/storage_common.c:242:3: error: implicit declaration of function 'blksize_bits' [-Werror=implicit-function-declaration]
>>
>> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
>> Cc: Andrzej Pietrasiewicz <andrzej.p@...sung.com>
>> Cc: Felipe Balbi <balbi@...com>
>
> Already have a patch for that
Thanks.
It wouldn't hurt to fix mainline so that it builds without this error, eh?
> commit bc912b0d237c1d376214616ae0c9d12b7d542ab4
> Author: Andrzej Pietrasiewicz <andrzej.p@...sung.com>
> Date: Mon Nov 4 13:46:17 2013 +0100
>
> usb: gadget: f_mass_storage: fix mass storage dependency
>
> Legacy gadgets supporting mass storage (g_mass_storage, g_acm_ms, g_multi)
> all depend on BLOCK.
>
> Make the standalone compilation of f_mass_storage (without any legacy
> gadget) dependent no BLOCK, too.
>
> Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@...sung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@...sung.com>
> Signed-off-by: Felipe Balbi <balbi@...com>
>
> diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> index a91e642..f66d96a 100644
> --- a/drivers/usb/gadget/Kconfig
> +++ b/drivers/usb/gadget/Kconfig
> @@ -682,6 +682,7 @@ config USB_CONFIGFS_PHONET
> config USB_CONFIGFS_MASS_STORAGE
> boolean "Mass storage"
> depends on USB_CONFIGFS
> + depends on BLOCK
> select USB_F_MASS_STORAGE
> help
> The Mass Storage Gadget acts as a USB Mass Storage disk drive.
>
--
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists