linux-kernel - Re: [PATCH] gadget: make USB_CONFIGFS_MASS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131209193116.GB28441@saruman.home>
Date:	Mon, 9 Dec 2013 13:31:16 -0600
From:	Felipe Balbi <balbi@...com>
To:	Randy Dunlap <rdunlap@...radead.org>
CC:	<balbi@...com>, USB list <linux-usb@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Andrzej Pietrasiewicz <andrzej.p@...sung.com>
Subject: Re: [PATCH] gadget: make USB_CONFIGFS_MASS_STORAGE depend on BLOCK

On Mon, Dec 09, 2013 at 11:27:31AM -0800, Randy Dunlap wrote:
> On 12/09/13 11:21, Felipe Balbi wrote:
> > On Mon, Dec 09, 2013 at 11:18:25AM -0800, Randy Dunlap wrote:
> >> From: Randy Dunlap <rdunlap@...radead.org>
> >>
> >> Make USB_CONFIGFS_MASS_STORAGE depend on BLOCK just like the other
> >> gadget MASS_STORAGE options do.  This fixes the following build errors
> >> that occur when BLOCK is not enabled:
> >>
> >> drivers/usb/gadget/storage_common.c: In function 'fsg_lun_open':
> >> drivers/usb/gadget/storage_common.c:241:3: error: implicit declaration of function 'bdev_logical_block_size' [-Werror=implicit-function-declaration]
> >> drivers/usb/gadget/storage_common.c:242:3: error: implicit declaration of function 'blksize_bits' [-Werror=implicit-function-declaration]
> >>
> >> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> >> Cc: Andrzej Pietrasiewicz <andrzej.p@...sung.com>
> >> Cc: Felipe Balbi <balbi@...com>
> > 
> > Already have a patch for that
> 
> Thanks.
> 
> It wouldn't hurt to fix mainline so that it builds without this error, eh?

I'm not the one who merges patches in Linus' tree, that's only up to
Linus eh ?

That patch is already in Greg's branch and he has already sent a pull
request to Linus.

If you're concerned it takes too long to fix build errors, you can ping
Linus to see if he'll merge Greg's pull request sooner. There's nothing
I can do.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)