linux-kernel - Re: [PATCH 35/41] tile: Replace __get_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <00000142dd1ad7dd-f4ddd24d-522c-4ec7-b40d-ff2fc167b52c-000000@email.amazonses.com>
Date:	Tue, 10 Dec 2013 15:23:13 +0000
From:	Christoph Lameter <cl@...ux.com>
To:	Chris Metcalf <cmetcalf@...era.com>
cc:	Tejun Heo <tj@...nel.org>, akpm@...uxfoundation.org,
	rostedt@...dmis.org, linux-kernel@...r.kernel.org,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 35/41] tile: Replace __get_cpu_var uses

On Mon, 9 Dec 2013, Chris Metcalf wrote:

> Except for a comment typo:
>
> >  /*
> >   * Read the set of maskable interrupts.
> > - * We avoid the preemption warning here via __this_cpu_ptr since even
> > + * We avoid the preemption warning here via raw_cpu_ptr since even
> >   * if irqs are already enabled, it's harmless to read the wrong cpu's
> >   * enabled mask.
> >   */
> >  #define arch_local_irqs_enabled() \
> > -	(*__this_cpu_ptr(&interrupts_enabled_mask))
> > +	raw_cpu_read(interrupts_enabled_mask)
>
> Should be raw_cpu_read() in the comment.

Ok fixed.

> I assume you are planning to submit these through your own tree, not the arch trees?

Well once the core pieces are in then they can go through the arch trees.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/