linux-kernel - Re: [PATCH 35/41] tile: Replace __get_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52A62D9D.5080105@tilera.com>
Date:	Mon, 9 Dec 2013 15:52:45 -0500
From:	Chris Metcalf <cmetcalf@...era.com>
To:	Christoph Lameter <cl@...ux.com>, Tejun Heo <tj@...nel.org>
CC:	<akpm@...uxfoundation.org>, <rostedt@...dmis.org>,
	<linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 35/41] tile: Replace __get_cpu_var uses

On 12/3/2013 6:33 PM, Christoph Lameter wrote:
> __get_cpu_var() is used for multiple purposes in the kernel source. One of
> them is address calculation via the form &__get_cpu_var(x).  This calculates
> the address for the instance of the percpu variable of the current processor
> based on an offset.
>
> [...]
>
> Cc: Chris Metcalf <cmetcalf@...era.com>
> Signed-off-by: Christoph Lameter <cl@...ux.com>

Acked-by: Chris Metcalf <cmetcalf@...era.com>

Except for a comment typo:

>  /*
>   * Read the set of maskable interrupts.
> - * We avoid the preemption warning here via __this_cpu_ptr since even
> + * We avoid the preemption warning here via raw_cpu_ptr since even
>   * if irqs are already enabled, it's harmless to read the wrong cpu's
>   * enabled mask.
>   */
>  #define arch_local_irqs_enabled() \
> -	(*__this_cpu_ptr(&interrupts_enabled_mask))
> +	raw_cpu_read(interrupts_enabled_mask)

Should be raw_cpu_read() in the comment.

I assume you are planning to submit these through your own tree, not the arch trees?

-- 
Chris Metcalf, Tilera Corp.
http://www.tilera.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/