linux-kernel - Re: [PATCH 06/13] staging/lustre/llite: remove ll_d_root

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+a=Yy5dRDD3ZLf-q5y5-UGn4RkRkgZQRDsKpaOYbVMaEFXhmA@mail.gmail.com>
Date:	Wed, 11 Dec 2013 11:23:12 +0800
From:	Peng Tao <bergwolf@...il.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Lai Siyao <laisiyao@...mcloud.com>,
	Lai Siyao <lai.siyao@...el.com>,
	Andreas Dilger <andreas.dilger@...el.com>
Subject: Re: [PATCH 06/13] staging/lustre/llite: remove ll_d_root_ops

On Wed, Dec 11, 2013 at 10:32 AM, Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
> On Mon, Dec 09, 2013 at 10:56:58PM +0800, Peng Tao wrote:
>> From: Lai Siyao <laisiyao@...mcloud.com>
>>
>> Mnt root dentry will never be revalidated, but its d_op->d_compare
>> will be called for its children, to simplify code, we use the same
>> ll_d_ops as normal dentries.
>> But its attribute may be invalid before access, this won't cause
>> any issue because it always exists, and the only operation depends
>> on its attribute is .permission, which has revalidated it in lustre
>> code.
>>
>> So it's okay to remove ll_d_root_ops, and remove unnecessary checks
>> in lookup/revalidate/statahead.
>
> This breaks the build.
>
> It's as if you aren't testing this.
>
err... I tested the series as a whole but it turns out this breakage
got fixed in the next patch. Looks like I should really have tested
every single patch instead.

sorry...

> I'm really tired of this, I really don't want to take any more patches
> from you for a while, as I dread them every time I see a series sent by
> you for this codebase.
>
I'll give you a break then... sorry for getting you annoyed.

Thanks,
Tao
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/