lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 11 Dec 2013 08:51:17 +0100 From: Sascha Hauer <s.hauer@...gutronix.de> To: Paul Walmsley <pwalmsley@...dia.com> Cc: Mikko Perttunen <mperttunen@...dia.com>, Arto Merilainen <amerilainen@...dia.com>, Thierry Reding <thierry.reding@...il.com>, Terje Bergström <tbergstrom@...dia.com>, linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org Subject: Re: [PATCH] gpu: host1x: clk_round_rate() can return a zero upon error On Mon, Dec 09, 2013 at 06:00:12PM -0800, Paul Walmsley wrote: > > Treat both negative and zero return values from clk_round_rate() as > errors. This is needed since subsequent patches will convert > clk_round_rate()'s return value to be an unsigned type, rather than a > signed type, since some clock sources can generate rates higher than > (2^31)-1 Hz. > > Eventually, when calling clk_round_rate(), only a return value of zero > will be considered a error. All other values will be considered valid > rates. The comparison against values less than 0 is kept to preserve > the correct behavior in the meantime. Shouldn't it be an error when the result is not within sensible limits instead? What do you do with a rate of 1Hz? Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists