[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Thu, 12 Dec 2013 16:11:59 +0100
From: Roger Pau Monné <roger.pau@...rix.com>
To: Ian Campbell <Ian.Campbell@...rix.com>,
Julien Grall <julien.grall@...aro.org>
CC: <xen-devel@...ts.xenproject.org>,
Stefano Stabellini <stefano.stabellini@...citrix.com>,
<linux-kernel@...r.kernel.org>,
David Vrabel <david.vrabel@...rix.com>, <patches@...aro.org>,
Boris Ostrovsky <boris.ostrovsky@...cle.com>,
<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [Xen-devel] [PATCH v2] xen/block: Correctly define structures
in public headers on ARM32 and ARM64
On 12/12/13 15:19, Ian Campbell wrote:
> On Tue, 2013-12-03 at 15:40 +0000, Julien Grall wrote:
>> On ARM (32 bits and 64 bits), the double-word is 8-bytes aligned. This will
>> result on different structure from Xen and Linux repositories.
>>
>> As Linux is using __packed__ attribute, it must have a 4-bytes padding before
>> each "id" field.
>>
>> This change breaks guest block support with older kernel. IMHO, it's acceptable
>> because Xen on ARM is still on Tech Preview and the hypercall ABI is not yet
>> freezed.
>>
>> Only one architecture (x86_32) doesn't have 64-bit ABI for the block interface.
>> Don't add padding if Linux is compiled for this architecture.
>
> Konrad asked for confirmation that this didn't change x86.
I've also tested this using various combinations of kernels, and it
seems to be perfectly fine, so:
Acked-by: Roger Pau Monné <roger.pau@...rix.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists