linux-kernel - Re: [PATCH] rt-tests: hackbench: fix for uninitialized start time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 12 Dec 2013 09:14:22 -0600
From:	Clark Williams <williams@...hat.com>
To:	Ciprian Barbu <ciprian.barbu@...aro.org>
Cc:	RT <linux-rt-users@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Linaro Networking <linaro-networking@...aro.org>
Subject: Re: [PATCH] rt-tests: hackbench: fix for uninitialized start time

On Thu, 12 Dec 2013 16:47:19 +0200
Ciprian Barbu <ciprian.barbu@...aro.org> wrote:

> Hello,
> 
> While playing around with hackbench I discovered that I would sometimes 
> get an enormous time reported, even if the run time would be less than a 
> second or so. The problem was that the struct timeval start was not 
> initialized until after all children have been created. But if the 
> program receives a signal before this is done, the start time is left 
> uninitialized.
> 
> I propose that in such situations an error message be displayed, like 
> the following patch does.
> 
> Please let me know if this is acceptable.
> 
> Regards,
> /Ciprian

Looks good to me. I've pulled it in for the next release.

Clark

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)