| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20131212185917.7ed6b21f@armhf>
Date: Thu, 12 Dec 2013 18:59:17 +0100
From: Jean-Francois Moine <moinejf@...e.fr>
To: Liam Girdwood <lgirdwood@...il.com>,
Mark Brown <broonie@...nel.org>
Cc: Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: [PATCH] ASoC: make snd_soc_dai_link more symmetrical
This patch renders optional the CODEC name / OF node on sound card register,
as it is done for the CPU side, in the case the CODEC DAI name is unique.
This simplifies the definition of CODECs with multiple DAIs, especially
in DTs, while keeping compatibility.
Signed-off-by: Jean-Francois Moine <moinejf@...e.fr>
---
include/sound/soc.h | 6 ++++--
sound/soc/soc-core.c | 73 ++++++++++++++++++++++++++++++++++++++++----------------------
2 files changed, 51 insertions(+), 28 deletions(-)
diff --git a/include/sound/soc.h b/include/sound/soc.h
index 1f741cb..67c382e 100644
--- a/include/sound/soc.h
+++ b/include/sound/soc.h
@@ -852,8 +852,10 @@ struct snd_soc_dai_link {
*/
const char *cpu_dai_name;
/*
- * You MUST specify the link's codec, either by device name, or by
- * DT/OF node, but not both.
+ * You MAY specify the link's codec, either by device name, or by
+ * DT/OF node, but not both. If this information is omitted,
+ * the CODEC DAI is matched using .codec_dai_name only, which hence
+ * must be globally unique.
*/
const char *codec_name;
const struct device_node *codec_of_node;
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index 4e53d87..11b729c 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -883,28 +883,54 @@ static int soc_bind_dai_link(struct snd_soc_card *card, int num)
return -EPROBE_DEFER;
}
- /* Find CODEC from registered CODECs */
- list_for_each_entry(codec, &codec_list, list) {
- if (dai_link->codec_of_node) {
- if (codec->dev->of_node != dai_link->codec_of_node)
- continue;
- } else {
- if (strcmp(codec->name, dai_link->codec_name))
- continue;
+ if (dai_link->codec_of_node || dai_link->codec_name) {
+
+ /* Find CODEC from registered CODECs */
+ list_for_each_entry(codec, &codec_list, list) {
+ if (dai_link->codec_of_node) {
+ if (codec->dev->of_node != dai_link->codec_of_node)
+ continue;
+ } else {
+ if (strcmp(codec->name, dai_link->codec_name))
+ continue;
+ }
+
+ rtd->codec = codec;
+
+ /*
+ * CODEC found, so find CODEC DAI from registered DAIs from
+ * this CODEC
+ */
+ list_for_each_entry(codec_dai, &dai_list, list) {
+ if (codec->dev == codec_dai->dev &&
+ !strcmp(codec_dai->name,
+ dai_link->codec_dai_name)) {
+
+ rtd->codec_dai = codec_dai;
+ }
+ }
+
+ if (!rtd->codec_dai) {
+ dev_err(card->dev, "ASoC: CODEC DAI %s not registered\n",
+ dai_link->codec_dai_name);
+ return -EPROBE_DEFER;
+ }
}
- rtd->codec = codec;
+ if (!rtd->codec) {
+ dev_err(card->dev, "ASoC: CODEC %s not registered\n",
+ dai_link->codec_name);
+ return -EPROBE_DEFER;
+ }
+ } else {
- /*
- * CODEC found, so find CODEC DAI from registered DAIs from
- * this CODEC
- */
+ /* find CODEC DAI from registered DAIs */
list_for_each_entry(codec_dai, &dai_list, list) {
- if (codec->dev == codec_dai->dev &&
- !strcmp(codec_dai->name,
+ if (!strcmp(codec_dai->name,
dai_link->codec_dai_name)) {
-
rtd->codec_dai = codec_dai;
+ rtd->codec = codec_dai->codec;
+ break;
}
}
@@ -915,12 +941,6 @@ static int soc_bind_dai_link(struct snd_soc_card *card, int num)
}
}
- if (!rtd->codec) {
- dev_err(card->dev, "ASoC: CODEC %s not registered\n",
- dai_link->codec_name);
- return -EPROBE_DEFER;
- }
-
/* if there's no platform we match on the empty platform */
platform_name = dai_link->platform_name;
if (!platform_name && !dai_link->platform_of_node)
@@ -3710,12 +3730,13 @@ int snd_soc_register_card(struct snd_soc_card *card)
struct snd_soc_dai_link *link = &card->dai_link[i];
/*
- * Codec must be specified by 1 of name or OF node,
- * not both or neither.
+ * Codec may be specified by either name or OF node,
+ * but can be left unspecified
+ * and will be matched based on CODEC DAI name alone.
*/
- if (!!link->codec_name == !!link->codec_of_node) {
+ if (link->codec_name && link->codec_of_node) {
dev_err(card->dev,
- "ASoC: Neither/both codec name/of_node are set for %s\n",
+ "ASoC: Both codec name/of_node are set for %s\n",
link->name);
return -EINVAL;
}
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists