linux-kernel - Re: [PATCH] ASoC: make snd_soc_dai

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131231165533.GK31886@sirena.org.uk>
Date:	Tue, 31 Dec 2013 16:55:33 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Jean-Francois Moine <moinejf@...e.fr>
Cc:	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: make snd_soc_dai_link more symmetrical

On Thu, Dec 12, 2013 at 06:59:17PM +0100, Jean-Francois Moine wrote:

> This patch renders optional the CODEC name / OF node on sound card register,
> as it is done for the CPU side, in the case the CODEC DAI name is unique.

> This simplifies the definition of CODECs with multiple DAIs, especially
> in DTs, while keeping compatibility.

So, this is similar to one of the comments I made on the DT patch you
sent today: you're saying that this makes things better but you're not
saying why it makes things better.  I've been sitting on this partly
because I've been wanting to sit down and try to work out what the
benefit is.  This information should be readily avaiable and omiting it
seems like it will make things more fragile.

If anything I'd expect DT to want to move towards specifying things by
CODEC plus optional DAI index rather than anything else, that's the more
common pattern for DT based things (really phandle plus index) and it's
what the current generic card is doing.

It's possible there is a benefit I'm just not seeing but you'll need to
tell me.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)