linux-kernel - Re: [PATCH v4 1/2] ARM: mach-moxart: add MOXA ART SoC platform files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 14 Dec 2013 17:26:25 +0100
From:	Jonas Jensen <jonas.jensen@...il.com>
To:	Guenter Roeck <linux@...ck-us.net>
Cc:	Arnd Bergmann <arnd@...db.de>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"arm@...nel.org" <arm@...nel.org>,
	Russell King - ARM Linux <linux@....linux.org.uk>,
	Olof Johansson <olof@...om.net>
Subject: Re: [PATCH v4 1/2] ARM: mach-moxart: add MOXA ART SoC platform files

On 14 December 2013 16:50, Guenter Roeck <linux@...ck-us.net> wrote:
> The above would at least avoid the crash, though I would not understand
> the point of having an unloadable restart handler. Forcing the watchdog
> driver into the kernel just because you want the restart handler in it
> would seem odd. And if the restart handler is optional, why have it
> in the first place ? I also don't follow Arnd's logic of wanting to have
> the code in the watchdog driver just because it happens to use a register
> that it needs.
>
> Conceptually it might be cleaner to write a separate driver, for example
> in drivers/power/restart, than plugging the functionality into
> the watchdog driver, at least if you don't want it in architecture
> or platform code. The xgene restart driver is a good example.
>
> Anyway, it is not up to me to accept the code, that is up to Wim.
> My rejection was primarily due to technical flaws, which can be addressed.
> For the logical reasoning you'll have to convince Wim.

Thanks for the replies.

Moving it to a new power/restart driver seems reasonable to me, I'm
really just looking for a home for it, I would have preferred a
hardware with reset in a separate register though.

I now plan to remove it for v5 and submit a separate driver.


Regards,
Jonas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/