linux-kernel - Re: [PATCH] drivers: md: Mark the function btree_insert

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131214204414.GK17601@leaf>
Date:	Sat, 14 Dec 2013 12:44:15 -0800
From:	Josh Triplett <josh@...htriplett.org>
To:	Rashika Kheria <rashika.kheria@...il.com>
Cc:	linux-kernel@...r.kernel.org, Kent Overstreet <kmo@...erainc.com>,
	Neil Brown <neilb@...e.de>, linux-bcache@...r.kernel.org,
	linux-raid@...r.kernel.org
Subject: Re: [PATCH] drivers: md: Mark the function btree_insert_fn() as
 static in btree.c

On Sat, Dec 14, 2013 at 06:29:29PM +0530, Rashika Kheria wrote:
> This patch marks the function btree_insert_fn() as static in
> bcache/btree.c because it is not used outside this file.
> 
> Thus, it also eliminates the following warning in bcache/btree.c:
> drivers/md/bcache/btree.c:2220:5: warning: no previous prototype for ‘btree_insert_fn’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@...il.com>

Reviewed-by: Josh Triplett <josh@...htriplett.org>

>  drivers/md/bcache/btree.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/md/bcache/btree.c b/drivers/md/bcache/btree.c
> index 5e2765a..dc6e2be 100644
> --- a/drivers/md/bcache/btree.c
> +++ b/drivers/md/bcache/btree.c
> @@ -2217,7 +2217,7 @@ struct btree_insert_op {
>  	struct bkey	*replace_key;
>  };
>  
> -int btree_insert_fn(struct btree_op *b_op, struct btree *b)
> +static int btree_insert_fn(struct btree_op *b_op, struct btree *b)
>  {
>  	struct btree_insert_op *op = container_of(b_op,
>  					struct btree_insert_op, op);
> -- 
> 1.7.9.5
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/