linux-kernel - Re: [PATCH] drivers: memstick: Mark function memstick_debug_get_tpc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131214204620.GL17601@leaf>
Date:	Sat, 14 Dec 2013 12:46:20 -0800
From:	Josh Triplett <josh@...htriplett.org>
To:	Rashika Kheria <rashika.kheria@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Maxim Levitsky <maximlevitsky@...il.com>
Subject: Re: [PATCH] drivers: memstick: Mark function
 memstick_debug_get_tpc_name() as static in r592.c

On Sat, Dec 14, 2013 at 06:37:18PM +0530, Rashika Kheria wrote:
> This patch marks the function memstick_debug_get_tpc_name() as static in
> host/r592.c because it is not used outside this file.
> 
> Thus, it also eliminates the following warning in host/r592.c:
> drivers/memstick/host/r592.c:50:13: warning: no previous prototype for ‘memstick_debug_get_tpc_name’ [-Wmissing-prototypes]

In this case, memstick_debug_get_tpc_name is exported.  However, nothing
in the kernel uses it.  Thus, I'd suggest additionally deleting the
EXPORT_SYMBOL for it, leaving it as a static function only used
internally within that file.

>  drivers/memstick/host/r592.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/memstick/host/r592.c b/drivers/memstick/host/r592.c
> index 31727bf..1cd9307 100644
> --- a/drivers/memstick/host/r592.c
> +++ b/drivers/memstick/host/r592.c
> @@ -47,7 +47,7 @@ static const char *tpc_names[] = {
>   * memstick_debug_get_tpc_name - debug helper that returns string for
>   * a TPC number
>   */
> -const char *memstick_debug_get_tpc_name(int tpc)
> +static const char *memstick_debug_get_tpc_name(int tpc)
>  {
>  	return tpc_names[tpc-1];
>  }
> -- 
> 1.7.9.5
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/