linux-kernel - Re: [RFC 4/5] usb: dwc3-exynos: enable async suspend/resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131218160736.GD4970@saruman.home>
Date:	Wed, 18 Dec 2013 10:07:36 -0600
From:	Felipe Balbi <balbi@...com>
To:	Yuvaraj Kumar C D <yuvaraj.cd@...il.com>
CC:	<stern@...land.harvard.edu>, <gregkh@...uxfoundation.org>,
	<kgene.kim@...sung.com>, <linux-usb@...r.kernel.org>,
	<sarah.a.sharp@...ux.intel.com>, <balbi@...com>,
	<gautam.vivek@...sung.com>, <joshi@...sung.com>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-samsung-soc@...r.kernel.org>, <linux-omap@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>,
	Andrew Bresticker <abrestic@...omium.org>,
	Yuvaraj Kumar C D <yuvaraj.cd@...sung.com>
Subject: Re: [RFC 4/5] usb: dwc3-exynos: enable async suspend/resume

On Wed, Dec 18, 2013 at 04:09:33PM +0530, Yuvaraj Kumar C D wrote:
> From: Andrew Bresticker <abrestic@...omium.org>
> 
> In addition to enabling async suspend/resume on the xhci-plat device,
> we must enable it for the dwc3-exynos platform device in order to make
> the full USB stack resume asynchronously.  Like the xhci-plat, ehci-s5p,
> and ohci-exynos drivers, there are no outside dependencies which would
> make resuming the dwc3-exynos driver asynchronously unsafe.
> 
> Signed-off-by: Andrew Bresticker <abrestic@...omium.org>
> Reviewed-by: Julius Werner <jwerner@...omium.org>
> Signed-off-by: Yuvaraj Kumar C D <yuvaraj.cd@...sung.com>
> ---
>  drivers/usb/dwc3/dwc3-exynos.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/usb/dwc3/dwc3-exynos.c b/drivers/usb/dwc3/dwc3-exynos.c
> index 8b20c70..57431b7 100644
> --- a/drivers/usb/dwc3/dwc3-exynos.c
> +++ b/drivers/usb/dwc3/dwc3-exynos.c
> @@ -155,6 +155,8 @@ static int dwc3_exynos_probe(struct platform_device *pdev)
>  		goto err2;
>  	}
>  
> +	device_enable_async_suspend(dev);

sure that clk_disable() in your ->suspend() callback will cause no
issues at all ?

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)