linux-kernel - Re: [PATCH v3 1/2] clk: add clk accuracy retrieval support

Open Source and information security mailing list archives

Message-ID: <52B34BE3.7000208@overkiz.com>
Date:	Thu, 19 Dec 2013 20:41:23 +0100
From:	boris brezillon <b.brezillon@...rkiz.com>
To:	Mike Turquette <mturquette@...aro.org>,
	Rob Landley <rob@...dley.net>,
	Rob Herring <rob.herring@...xeda.com>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Stephen Warren <swarren@...dotorg.org>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Russell King <linux@....linux.org.uk>,
	Nicolas Ferre <nicolas.ferre@...el.com>,
	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
CC:	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH v3 1/2] clk: add clk accuracy retrieval support

Le 19/12/2013 20:36, Mike Turquette a écrit :
> Quoting boris brezillon (2013-12-19 00:54:07)
>> Hello Mike,
>>
>> On 19/12/2013 07:04, Mike Turquette wrote:
>>> Quoting Boris BREZILLON (2013-12-17 06:36:22)
>>>> +unsigned long __clk_get_accuracy(struct clk *clk)
>>>> +{
>>>> +       unsigned long ret;
>>>> +
>>>> +       if (!clk)
>>>> +               return 0;
>>>> +
>>>> +       return clk->accuracy;
>>>> +}
>>>> +EXPORT_SYMBOL_GPL(__clk_get_accuracy);
>>> Any reason for exporting this?
>> This might be used by clk drivers to choose the most accurate clk
>> among its parent clks (within the determinate_rate callback).
>>
>> And as some clk drivers might be compiled as modules we need
>> to export the symbol (__clk_get_name helper function is exported
>> too).
> Does your driver need this or is this just following the existing
> __clk_get_rate / clk_get_rate model?

No, I don't need this for my driver, at least for the moment.

Do you want me to drop this EXPORT_SYMBOL ?
>
> Regards,
> Mike
>
>> Best Regards,
>>
>> Boris
>>> Regards,
>>> Mike
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@...ts.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives