linux-kernel - Re: [PATCH 29/40] mips: Replace __get_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52B37C56.7090302@gmail.com>
Date:	Thu, 19 Dec 2013 15:08:06 -0800
From:	David Daney <ddaney.cavm@...il.com>
To:	Christoph Lameter <cl@...ux.com>,
	Ralf Baechle <ralf@...ux-mips.org>,
	linux-mips <linux-mips@...ux-mips.org>
CC:	Tejun Heo <tj@...nel.org>, akpm@...uxfoundation.org,
	rostedt@...dmis.org, linux-kernel@...r.kernel.org,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 29/40] mips: Replace __get_cpu_var uses

On 12/19/2013 01:10 PM, Christoph Lameter wrote:
> On Thu, 19 Dec 2013, David Daney wrote:
>
>>> 16:07:58.244398747 -0600
>>> @@ -43,7 +43,7 @@ DECLARE_PER_CPU(struct mips_fpu_emulator
>>>    #define MIPS_FPU_EMU_INC_STATS(M)					\
>>>    do {
>>> \
>>>    	preempt_disable();						\
>>> -	__local_inc(&__get_cpu_var(fpuemustats).M);			\
>>> +	__this_cpu_inc(fpuemustats.M);					\
>>>    	preempt_enable();						\
>>>    } while (0)
>>>
>>
>> Something seems to be incorrect in this bit.
>
> Hrmm.. yes this is a local_t so the this_cpu_inc would not work unless
> fpuemustats is defined differently.
>

See the attached patch.  Feel free to include it as part of your patch set.

I tested it on a 64-bit OCTEON system.  I think it will work on 32-bit 
systems as well.

> Use
>
> __local_inc(this_cpu_ptr(fpuemustats.M);
>

No, I couldn't get various incantations of that to work either.

> instead until then.
>


View attachment "0001-MIPS-Replace-__get_cpu_var-uses-in-FPU-emulator.patch" of type "text/x-patch" (2183 bytes)