linux-kernel - Re: [PATCH 4/7] drivers: usb: Include appropriate header file in pci-quirks.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1312191047440.984-100000@iolanthe.rowland.org>
Date:	Thu, 19 Dec 2013 10:51:50 -0500 (EST)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Rashika Kheria <rashika.kheria@...il.com>
cc:	linux-kernel@...r.kernel.org,
	Sarah Sharp <sarah.a.sharp@...ux.intel.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<linux-usb@...r.kernel.org>, <josh@...htriplett.org>
Subject: Re: [PATCH 4/7] drivers: usb: Include appropriate header file in
 pci-quirks.c

On Thu, 19 Dec 2013, Rashika Kheria wrote:

> Include header file include/linux/usb/hcd.h in host/pci-quirks.c because
> function usb_hcd_amd_remote_wakeup_quirk() has its prototype declaration
> in include/linux/usb/hcd.h.
> 
> This eliminates the following warning in host/pci-quirks.c:
> drivers/usb/host/pci-quirks.c:253:5: warning: no previous prototype for ‘usb_hcd_amd_remote_wakeup_quirk’ [-Wmissing-prototypes]

Since when does the compiler complain about functions with no 
prototype?

In any case, I think it would make more sense to move the prototype 
declaration into drivers/usb/host/pci-quirks.h, and have 
drivers/usb/core/hcd-pci.c include that file.  After all, it's 
perfectly reasonable for hcd-pci to want to know about the quirks of 
various PCI-based controllers, but it's not reasonable for pci-quirks.c 
to need to know about the details of HCDs.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/