linux-kernel - Re: [RFC/PATCH 0/3] pm: Make SET_*_PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131219051229.GA27854@psi-dev26.jf.intel.com>
Date:	Wed, 18 Dec 2013 21:12:29 -0800
From:	David Cohen <david.a.cohen@...ux.intel.com>
To:	pavel@....cz, rjw@...ysocki.net, len.brown@...el.com,
	sarah.a.sharp@...ux.intel.com, gregkh@...uxfoundation.org
Cc:	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org, santosh.shilimkar@...com
Subject: Re: [RFC/PATCH 0/3] pm: Make SET_*_PM_OPS() macros more smart

On Thu, Dec 12, 2013 at 09:18:22PM -0800, David Cohen wrote:
> Hi,
> 
> These patches are proposal to extend the lack of #ifdef checks on PM callback
> to its implementation too.
> 
> Currently SET_*_PM_OPS() macros make #ifdefs checks not necessary when setting
> the callback to PM ops, but the callbacks implementation don't see same
> benefit.
> 
> This RFC Solves a problem reported by Santosh on xhci-plat.c driver due to
> wrong #ifdef checks:
> 
> drivers/usb/host/xhci-plat.c:201:12: warning: ‘xhci_plat_suspend’ defined but not used [-Wunused-function]
> drivers/usb/host/xhci-plat.c:209:12: warning: ‘xhci_plat_resume’ defined but not used [-Wunused-function]
> 
> But instead of fixing the #ifdefs, we remove the need for it :)

Ping. Comments here? :)

Br, David

> 
> Br, David Cohen
> 
> ---
> David Cohen (2):
>   pm: make PM macros more smart
>   usb/xhci: implement proper static inline stubs when !CONFIG_PM
> 
> Santosh Shilimkar (1):
>   usb/xhci-plat: remove unnecessary #ifdef checks for CONFIG_PM_SLEEP
> 
>  drivers/usb/host/xhci-plat.c |  7 +------
>  drivers/usb/host/xhci.h      |  6 ++++--
>  include/linux/pm.h           | 11 +++++++++--
>  3 files changed, 14 insertions(+), 10 deletions(-)
> 
> -- 
> 1.8.4.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/