linux-kernel - Re: [RFT][PATCH] pinctrl: msm: Fix set gpio setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZEagq1xBuj7QCYkA2-961OPseNOQH3upTfASaxUk_ZTg@mail.gmail.com>
Date:	Fri, 20 Dec 2013 10:14:36 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Axel Lin <axel.lin@...ics.com>
Cc:	Bjorn Andersson <bjorn.andersson@...ymobile.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RFT][PATCH] pinctrl: msm: Fix set gpio setting

On Fri, Dec 13, 2013 at 2:35 PM, Axel Lin <axel.lin@...ics.com> wrote:

> Set g->out_bit bit for gpio output high, clear g->out_bit bit for gpio output
> low.
>
> Signed-off-by: Axel Lin <axel.lin@...ics.com>
> ---
> Hi Bjorn,
> I don't have the datasheet, just found current code does not make sense
> because current code unconditionally set BIT(g->out_bit) in msm_gpio_set.
> I assume setting g->out_bit bit for gpio output high, clear the bit
> for gpio output low.
> Please check if this patch is correct.

I've tentatively applied this as Björn is busy right now, and I got a
sort-of-ack over IRC. If it turns out to be problematic we can revisit
this later.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/