linux-kernel - Re: [PATCH 1/6] perf report: Use pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87eh58e21p.fsf@sejong.aot.lge.com>
Date:	Fri, 20 Dec 2013 10:36:34 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Ingo Molnar <mingo@...nel.org>,
	Namhyung Kim <namhyung.kim@....com>,
	LKML <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>
Subject: Re: [PATCH 1/6] perf report: Use pr_*() functions if possible

Hi Jiri,

On Thu, 19 Dec 2013 14:31:54 +0100, Jiri Olsa wrote:
> On Thu, Dec 19, 2013 at 04:00:06PM +0900, Namhyung Kim wrote:
>> From: Namhyung Kim <namhyung.kim@....com>
>> 
>> There're some places printing a message to stdout/err directly.  It
>> should be converted to use proper error printing functions instead.
>> 
>> If it's not possible, just do it when --stdio was enabled only.
>> 
>> Signed-off-by: Namhyung Kim <namhyung@...nel.org>
>
> Maybe it'd be worthwhile to factor perf_session__fprintf*
> functions so the info could end up in the log window.

I thought about it too.  And then considered something like below:

  FILE *sfp = open_memstream(&ptr, &size);
  perf_session__fprintf*(session, sfp, ...);
  fclose(sfp);

  perf_log_add(ptr);
  fprintf(orig_fp, "%s", ptr);

  free(ptr);


What do you think?

>
> Acked-by: Jiri Olsa <jolsa@...hat.com>

Thanks!
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/