linux-kernel - Re: checkpatch.pl error might be false positive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131220170308.GA26163@leaf>
Date:	Fri, 20 Dec 2013 09:03:09 -0800
From:	Josh Triplett <josh@...htriplett.org>
To:	Joe Perches <joe@...ches.com>
Cc:	Ravi Patel <rapatel@....com>,
	Jesse Brandeburg <jesse.brandeburg@...el.com>,
	Andy Whitcroft <apw@...onical.com>,
	Kumar Sankaran <ksankaran@....com>, Loc Ho <lho@....com>,
	Keyur Chudgar <kchudgar@....com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: checkpatch.pl error might be false positive

On Fri, Dec 20, 2013 at 01:23:52AM -0800, Joe Perches wrote:
> On Fri, 2013-12-20 at 01:16 -0800, Josh Triplett wrote:
> > Duplicating the regex seems awful.  Could you put it in a variable?
> 
> awful is a strong word and I don't have any
> issue with the duplication.  Using a variable
> is just as confusing as any duplication.

Fair enough; I don't care that much.  For your patch:
Reviewed-by: Josh Triplett <josh@...htriplett.org>

- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/