linux-kernel - Re: [PATCHv2 1/3] silicom: fix whitespace issues in bypass.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 20 Dec 2013 22:35:43 +0530
From:	Gokulnath A <gokul.linux@...il.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	Michael Hoefler <michael.hoefler@...dium.uni-erlangen.de>,
	"open list:STAGING SUBSYSTEM" <devel@...verdev.osuosl.org>,
	linux-kernel@...cs.fau.de,
	Christoph Kohl <christoph.kohl@...nline.de>,
	open list <linux-kernel@...r.kernel.org>,
	Rupert Muchembled <rupert@...ch.net>
Subject: Re: [PATCHv2 1/3] silicom: fix whitespace issues in bypass.c

On Fri, Dec 20, 2013 at 10:31 PM, Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
> On Fri, Dec 20, 2013 at 08:36:48PM +0530, Gokulnath A wrote:
>> Hello Michael,
>>
>> On Fri, Dec 20, 2013 at 7:21 PM, Michael Hoefler
>> <michael.hoefler@...dium.uni-erlangen.de> wrote:
>> > This patch addresses several problems in bypass.c found by checkpatch.
>> > Furthermore it removes/adds some empty lines to make the code more readable.
>> >
>> > The following problems are fixed:
>> >  - line over 80 characters
>> >  - space after logical operator !
>> >  - spaces instead of tabs
>> >  - missing empty line after local declarations
>> >  - empty line after {
>> >
>>
>> Please do one thing per patch, As Greg suggested for me in previous mail
>> conversations. Here you could have at least 3 or 4 patches.
>> For example, first patch would be a fix for line over 80 characters,
>> followed by the other problems as mentioned above by you.
>
> Nah, all of these are affecting the same macros, so it's ok, I'll take
> it as-is.

ok. Sorry for the comments and thanks for information.

>
> thanks,
>
> greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/